feat: 131 add redirect field #309
Conversation
|
|
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md
If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.
| # Don't upload to Google Cloud if it was triggered by hand. | ||
| # In that case the resulting sources.csv can be found in the build artifacts. | ||
| if: ${{ github.event_name != 'workflow_dispatch' }} |
There was a problem hiding this comment.
question: There is no harm uploading the artifact to Google cloud. Why prevent it?
There was a problem hiding this comment.
I added the workflow_dispatch as a way to test the creation of the csv. The only way that I know to have the button workflow dispatch present to run the action in a branch is if the event is present in the main branch. I don't feel comfortable uploading it each time someone presses the button. But I could remove the restriction if you feel it's ok.
Closes #131
Added redirects to the json schema.
Modified export to csv script to process redirects.
This PR has an associated issue in mobility-feed-api: MobilityData/mobility-feed-api#149
And PR: MobilityData/mobility-feed-api#150