Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store latest datasets cronjob size limit #299

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

davidgamez
Copy link
Member

Description

The store latest datasets cronjob is failing, blocking the downloads and verification of all datasets. The failure is due to the GitHub step/job output size. In this PR, the step output is replaced with the "new" Github output pattern, and the latest URL prefix is removed from the output to reduce the number of characters of the job results.

Expected behavior

The store latest datasets cronjob runs successfully.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md

If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.

@davidgamez davidgamez changed the title fix: store latest datasets cronjob size limit fix: Store latest datasets cronjob size limit Sep 13, 2023
schedule:
- cron: "0 0 * * *"

env:
URL_STORAGE_PREFIX: "https://storage.googleapis.com/storage/v1/b/mdb-latest/o"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for now, but we should consider another way to specify this prefix in case we ever change the location of the datasets.

@davidgamez davidgamez merged commit eab1ac7 into main Sep 13, 2023
8 checks passed
@davidgamez davidgamez deleted the fix/cron-job-size-limit branch September 13, 2023 16:06
@github-actions
Copy link
Contributor

Congrats on getting your first pull request merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Why are the feeds from a direct_download and latest not the same?
2 participants