Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Python script to track usage of best practices in Mobility Database feeds #72 #275

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 13, 2023

This script runs a report to assess

Closes #72

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cka-y
❌ qcdyx
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cka-y cka-y changed the title feat: create Python script to track usage of best practices in Mobility Database feeds #72 feat: Create Python script to track usage of best practices in Mobility Database feeds #72 Jun 13, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md

If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.

@@ -0,0 +1,121 @@
from zipfile import ZipFile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Please add a documentation header to Python scripts with a brief usage description and parameters if applicable.

Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcdyx qcdyx merged commit 07b58e2 into main Sep 26, 2023
7 checks passed
@qcdyx qcdyx deleted the feat/72 branch September 26, 2023 12:23
@github-actions
Copy link
Contributor

Congrats on getting your first pull request merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants