-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Python script to track usage of best practices in Mobility Database feeds #72 #275
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md
If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.
@@ -0,0 +1,121 @@ | |||
from zipfile import ZipFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Please add a documentation header to Python scripts with a brief usage description and parameters if applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This script runs a report to assess
shape_dist_traveled
must not exceed the trip shape's maximum distance google/transit#380 and Forbid subfolders in GTFS files google/transit#379 are being used by the community in feeds on the Mobility DatabaseThis script will help us understand how to best make changes to the spec.
Closes #72