Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monthly update] Nov-Dec 2024 #559

Merged
merged 23 commits into from
Dec 19, 2024
Merged

[Monthly update] Nov-Dec 2024 #559

merged 23 commits into from
Dec 19, 2024

Conversation

Sergiodero
Copy link
Contributor

@Sergiodero Sergiodero commented Dec 17, 2024

This PR updates the following files in EN, FR, JA and ES to align with the latest changes in the google/transit repo:

  • Schedule Reference
  • Realtime Reference
  • Realtime Protobuf page
  • Realtime Protobuf file
  • Realtime Revision History

Changes consist of:

@skalexch do you mind reviewing the English files (just to confirm that changes look good) and the French translation? Thanks!

@fredericsimard could you take a quick look at the JA translation? thanks!

@Sergiodero Sergiodero requested a review from skalexch December 17, 2024 22:07
Copy link

@skalexch skalexch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sergiodero most is fine except for one detail to fix in the french translation. It is "Ajout de" instead of just "ajout".
So:

  • "Ajout de field_name" instead of "ajout field_name".
  • "Ajout d'un"... Instead of "ajout un".

@Sergiodero
Copy link
Contributor Author

Thanks @skalexch FR text is now updated!

Copy link
Contributor

@fredericsimard fredericsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sergiodero
Copy link
Contributor Author

Thank you both @skalexch @fredericsimard! after finishing with the ES translation I'm now merging the changes.

@Sergiodero Sergiodero merged commit 325027e into main Dec 19, 2024
@Sergiodero Sergiodero deleted the monthly-update-NovDec2024 branch December 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants