feat: modified stop_too_far_from_shape so it only checks stop times record with a stop_id #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that have a stop_id. It should ignore stop times that don't have a stop_id.
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 24f89dd 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
qcdyx
deleted the
1881-modify-stop_too_far_from_shape-to-only-check-stop_timestxt-rows-with-stop_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1881
Expected behavior:
modified stop_too_far_from_shape so it only checks stop times records that have a stop_id. It should ignore stop times that don't have a stop_id.
Before:
After:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything