-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reformat trip and shape dist validator #1676
Conversation
✅ Rule acceptance tests passed. |
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice description + name minor revisions.
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
Outdated
Show resolved
Hide resolved
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive, again!
❌ Invalid acceptance test. |
Summary:
Resolves #1613 and #1611 by implementing a distance threshold for the
trip_distance_exceeds_shape_distance
notice.Expected Behavior:
trip_distance_exceeds_shape_distance
, triggering anERROR
for distancestrip_distance_exceeds_shape_distance_below_threshold
, withWARNING
severity for distancesERROR
level notices such asdecreasing_or_equal_stop_time_distance
anddecreasing_shape_distance
.Empirical Performance Comparison:$n$ as the number of trips, $m$ as the number of stop-times, and $k$ as the number of shapes, the complexity in the worst-case scenario:
Considering
master
branch isfeat/1613
) isStatistical Performance Comparison:
The performance improvements are depicted in the graph below. The datasets analyzed are from our catalog, with zipped file sizes of at least 1MB. Sizes have been normalized for a more meaningful comparison of slopes. The performance slope of the feature branch is significantly lower, decreasing from approximately 37 to approximately 25, indicating enhanced efficiency.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything