Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-20817] Handle case taskMetrics=null #313

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 17, 2024

Change Summary

Update SparkMetricsRecorder & co to handle case when taskEndEvent.taskMetrics() is null.

Added tests covering exception raised on Spark executor side. Unfortunately, this does not trigger this check, because it can be reproduced only in environment with spark.master=yarn or spark.master=k8s, and caused by OOM killer, not just task failure.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.45%. Comparing base (c18a4f2) to head (a4ea2a6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
onetl/_metrics/listener/task.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #313      +/-   ##
===========================================
+ Coverage    95.23%   95.45%   +0.22%     
===========================================
  Files          225      225              
  Lines         8984     8986       +2     
  Branches       894      895       +1     
===========================================
+ Hits          8556     8578      +22     
+ Misses         307      290      -17     
+ Partials       121      118       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit a97e63b into develop Oct 17, 2024
36 of 37 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-20817 branch October 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants