-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-16999] - Add jdbc_dialect logging #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #305 +/- ##
===========================================
+ Coverage 95.24% 95.40% +0.16%
===========================================
Files 225 225
Lines 8931 8940 +9
Branches 1516 1516
===========================================
+ Hits 8506 8529 +23
+ Misses 303 290 -13
+ Partials 122 121 -1 ☔ View full report in Codecov by Sentry. |
dolfinus
reviewed
Aug 20, 2024
dolfinus
reviewed
Aug 20, 2024
dolfinus
reviewed
Aug 20, 2024
tests/tests_integration/tests_db_connection_integration/test_clickhouse_integration.py
Outdated
Show resolved
Hide resolved
Dialect should be logged in every place it is used for constructing JDBC dataframe:
|
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 11:33
d73c485
to
175e1b9
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 11:33 — with
GitHub Actions
Inactive
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 11:34
175e1b9
to
4dc8b56
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 11:34 — with
GitHub Actions
Inactive
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 11:35
4dc8b56
to
81d86f6
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 11:35 — with
GitHub Actions
Inactive
dolfinus
reviewed
Aug 20, 2024
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 11:50 — with
GitHub Actions
Inactive
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 12:53
97d49b9
to
b09735a
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 12:53 — with
GitHub Actions
Inactive
dolfinus
reviewed
Aug 20, 2024
tests/tests_integration/tests_db_connection_integration/test_clickhouse_integration.py
Outdated
Show resolved
Hide resolved
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 13:11
b09735a
to
6b83824
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 13:11 — with
GitHub Actions
Inactive
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 14:18
6b83824
to
86001d3
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 14:18 — with
GitHub Actions
Inactive
dolfinus
reviewed
Aug 20, 2024
tests/tests_integration/tests_db_connection_integration/test_postgres_integration.py
Outdated
Show resolved
Hide resolved
maxim-lixakov
force-pushed
the
feature/DOP-16999
branch
from
August 20, 2024 14:41
86001d3
to
7d0f3a0
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
August 20, 2024 14:41 — with
GitHub Actions
Inactive
dolfinus
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add logging info about using jdbc dialect in jdbc connections in
get_df_schema
method:If no dialect is defined (in case like Clickhouse):
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)