Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-16999] - Add jdbc_dialect logging #305

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Aug 16, 2024

Change Summary

Add logging info about using jdbc dialect in jdbc connections in get_df_schema method:

2024-08-16 16:16:49,388 [INFO    ] MainThread: |Postgres| Detected dialect: 'org.apache.spark.sql.jdbc.PostgresDialect'

If no dialect is defined (in case like Clickhouse):

2024-08-16 15:47:57,800 [INFO    ] MainThread: |Clickhouse| Detected dialect: 'org.apache.spark.sql.jdbc.NoopDialect'

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov self-assigned this Aug 16, 2024
@maxim-lixakov maxim-lixakov marked this pull request as ready for review August 16, 2024 13:30
@maxim-lixakov maxim-lixakov requested a review from TiGrib August 16, 2024 13:30
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (1382600) to head (7d0f3a0).
Report is 62 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
+ Coverage    95.24%   95.40%   +0.16%     
===========================================
  Files          225      225              
  Lines         8931     8940       +9     
  Branches      1516     1516              
===========================================
+ Hits          8506     8529      +23     
+ Misses         303      290      -13     
+ Partials       122      121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus self-requested a review August 20, 2024 07:31
@dolfinus
Copy link
Member

Dialect should be logged in every place it is used for constructing JDBC dataframe:

  • JDBCConnection.get_df_schema
  • JDBCConnection.sql
  • JDBCMixin.fetch
  • JDBCMixin.execute

@maxim-lixakov maxim-lixakov merged commit f4d1f3d into develop Aug 20, 2024
34 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-16999 branch August 20, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants