Create param files with absolute path #3115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongjincho92
commented
Dec 12, 2024
| @@ -1092,6 +1094,9 @@ def _write_target_build_settings( | |||
| swift_args, | |||
| swift_debug_settings_to_merge = EMPTY_DEPSET, | |||
| team_id = None, | |||
| xcode_config, | |||
There was a problem hiding this comment.
@brentleyjones Got a question on handling this param in the unit test for this function. Right now, apple_support.run() would try to validate xcode_config and fails in unit test.
I would like to mock XcodeVersionConfig, but can we even mock it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would make the index-compile for single source file (.m and .mm) to not depend on params file generated by index-build of the target containing the source file.