Filter environment variables when building with Bazel #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobmattrob
approved these changes
Aug 19, 2024
thiagohmcruz
approved these changes
Aug 19, 2024
brentleyjones
force-pushed
the
bj/filter-env-more
branch
2 times, most recently
from
3bc7c61 to
83c0791
Compare
thiagohmcruz
approved these changes
Aug 19, 2024
brentleyjones
force-pushed
the
bj/filter-env-more
branch
from
83c0791 to
55de2a9
Compare
In order for Xcode builds to work with custom environment variables you need to use `xcodeproj.bazel_env`. This just takes the extra step of filtering out all other environment variables, ensuring more analysis cache hits. You can already do this in your own `tools/bazel`, but now people can get the benefit regardless. This change is needed for shared outputs bases to be performant. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/filter-env-more
branch
from
55de2a9 to
aa1d9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for Xcode builds to work with custom environment variables you need to use
xcodeproj.bazel_env. This just takes the extra step of filtering out all other environment variables, ensuring more analysis cache hits. You can already do this in your owntools/bazel, but now people can get the benefit regardless.This change is needed for shared outputs bases to be performant.