Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make indexbuild macos QoS 'utility' by default #3070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AngelaGuardia
Copy link

What changed?

  • Adds startup flag to set index builds MacOS QoS to utility by default

Why did it change?

  • Developers have reported excessive battery usage related to background indexing

How is it tested?

  • Added debug statements to the bazel_build.sh to see the startup flag being added for index builds
  • I was unable to directly confirm (via my macbook) that the java process was actually set to utility - open to suggestions on how to do this.

@AngelaGuardia AngelaGuardia requested a review from a team as a code owner August 9, 2024 14:31
@thiagohmcruz
Copy link
Contributor

cc @brentleyjones, thoughts on this change? Also, I can't see build results when clicking on the links to jobs here, is it because of it's based on @AngelaGuardia's fork?

Last, @AngelaGuardia I believe you'd have to update fixtures too in this PR.

@AngelaGuardia
Copy link
Author

Tried confirming that this change actually changes the qos of the bazel process by using this command sudo powermetrics --show-process-qos --show-process-qos-tiers --show-cpu-qos --samplers tasks -n 1 but I still don't see concrete proof that the flag actually changes the qos

@brentleyjones
Copy link
Contributor

With the merged output bases I don't believe we can, or would want to, take this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants