This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Fix TCP packet reordering on android, "unknown socket id" on iOS #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
readyToRead
as this code does on Android causes TCP packets to be assembled in an incorrect order, resulting in stream data corruption.However it seems calling
readyToRead
on iOS is absolutely necessary, or you won't get any data at all.Fixes #14 and #26