init devices with attach() function and not via constructor #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware for this pull request: |
|
Firmware for this pull request: |
neilenns
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
For the devices
AnalogInandButtonsanattach()function ia added where all required init paramaters are transferred. These init parameters were part of the constructor.Now calling the constructor will only set that the device is not initialized.
The calling of the constructor is since PR #253 also done to calculate the required memory for all devices of one type and to reserve it. As no init parameters are available at this point the standard paramaters were taken and e.g. pin 1 for the output and analogIn device was set output / input.
The required changes for outputs are part of PR #285.
For the InputShifter the default value in the constructor is deleted. Not required here as it gets set also in the attach() function.
For the servo device the not required constructor was deleted.
For the stepper the default parameters in the attach() function are deleted to be the same as the other devices.
Fixes #284