Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of fixed device numbers #253

Merged
merged 34 commits into from
Nov 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
03c36c8
dynamical button numbers
elral Aug 19, 2023
45edfaf
set up array function
elral Aug 19, 2023
ce9d55c
better comments
elral Aug 19, 2023
701dcc1
all devices with dymically defined array
elral Aug 20, 2023
088167d
changes for MUX
elral Aug 20, 2023
c080f58
missing defines added
elral Aug 21, 2023
34e83fc
missing return statement
elral Aug 21, 2023
1762966
back to original device memory space
elral Aug 21, 2023
03ec932
debug print out added
elral Aug 21, 2023
97ed2d6
extended information of memory usage to serial, deactivated
elral Aug 21, 2023
838888e
clean up, delete max. number of devices from board file
elral Aug 21, 2023
f77ebe8
get servos to run
elral Aug 21, 2023
dcbb30a
add comment for array size
elral Aug 23, 2023
cb038b2
get array size via an array
elral Aug 23, 2023
f2b0955
error handling added
elral Aug 23, 2023
666fec8
better definition of array size
elral Aug 23, 2023
ea09be0
intended size for nameBuffer[]
elral Sep 6, 2023
e3fe451
increased deviceBuffer for AVR's, decreased for Pico
elral Sep 6, 2023
6230b32
Merge branch 'main' into no_fixed_device_numbers
elral Sep 8, 2023
8584aaa
Merge branch 'MobiFlight:main' into no_fixed_device_numbers
elral Oct 11, 2023
517385b
max. numbers of devices not required anymore
elral Oct 13, 2023
63f9c36
one common function for sending failure message
elral Oct 15, 2023
8dd5291
failure message directly from flash
elral Oct 15, 2023
096be82
better naming
elral Oct 15, 2023
27abcd9
delete not required parameter in handler functions
elral Oct 15, 2023
0db4409
Revert "delete not required parameter in handler functions"
elral Oct 17, 2023
50a7526
Merge branch 'main' into no_fixed_device_numbers
elral Oct 21, 2023
018b451
merge branch main
elral Oct 21, 2023
4e8eba1
delete not required folder
elral Oct 23, 2023
8cb5d3b
Merge branch 'main' into no_fixed_device_numbers
elral Oct 23, 2023
d2a42d5
Merge branch 'main' into no_fixed_device_numbers
elral Oct 23, 2023
daac96f
merge branch main
elral Oct 23, 2023
64403aa
also custom devices w/o device limit
elral Oct 25, 2023
910f7b2
setup array for custom device was missing
elral Oct 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ enum {
kTypeMuxDriver, // 13 Multiplexer selector support (generates select outputs)
kTypeDigInMux, // 14 Digital input multiplexer support (example: 74HCT4067, 74HCT4051)
kTypeStepper // new stepper type with settings for backlash and deactivate output
// if new device types are added, change 'kTypeStepper' for the array numberDevices[] in readConfig() to the new one!!
Copy link
Contributor

@GioCC GioCC Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: add a last entry like this (comments removed for clarity)

    // ...
    kTypeDigInMux,
    kTypeStepper,
    // Add new devices here,
    kTypeMAXCOUNT

and use that value for the array size in getArraysizes(). This way no manual update will be required when adding devices.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again a very good idea!

// Otherwise the array inde will be exceeded
};

void loadConfig(void);
Expand Down