Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/login exoplayer #2

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat/login exoplayer #2

wants to merge 2 commits into from

Conversation

MoatazBadawy
Copy link
Owner

@MoatazBadawy MoatazBadawy commented Aug 11, 2023

Created video player custom class to play intro video in the background, I used Media3 for ExoPlayer as Exoplayer 2 is now deprecated see Media3 Decuomntaion

Features:

  • Play video when loading the activity
  • Display Image before video, to enhance the user experience. "Before the video playing and the video loading, ExoPlayer displays a black screen, so we display the first shoot from the video as it will be the user it is loading or preparing the video for him".
  • Loop the video
259954623-0fbf8a12-082e-4b2b-8ab6-0469e036b78b22.mp4

@gitguardian
Copy link

gitguardian bot commented Aug 11, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7657697 Company Email Password 7a962be app/src/main/res/values-night/strings.xml View secret
7657697 Company Email Password 7a962be app/src/main/res/values/strings.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@MoatazBadawy MoatazBadawy self-assigned this Aug 11, 2023
@MoatazBadawy MoatazBadawy added the enhancement New feature or request label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant