Improve Templates deletion validation #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
176cb64
to
f27b9ce
Compare
eromanova
force-pushed
the
template-validation
branch
4 times, most recently
from
8fa5584
to
5d46cee
Compare
Kshatrix
requested changes
Sep 27, 2024
eromanova
force-pushed
the
template-validation
branch
from
5d46cee
to
f01b819
Compare
eromanova
force-pushed
the
template-validation
branch
from
f01b819
to
fb3d9e0
Compare
eromanova
changed the title
eromanova
force-pushed
the
template-validation
branch
from
fb3d9e0
to
7dbda57
Compare
Kshatrix
requested changes
Oct 21, 2024
eromanova
force-pushed
the
template-validation
branch
from
7dbda57
to
03becc2
Compare
eromanova
force-pushed
the
template-validation
branch
from
03becc2
to
83d4900
Compare
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
ee7c734
to
995c17f
Compare
eromanova
force-pushed
the
template-validation
branch
from
995c17f
to
d24f391
Compare
eromanova
force-pushed
the
template-validation
branch
4 times, most recently
from
f210ccb
to
aa3e359
Compare
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
5c08a8c
to
220b985
Compare
eromanova
force-pushed
the
template-validation
branch
from
220b985
to
30564da
Compare
The following rules are validated: 1. ClusterTemplate or ServiceTemplate can't be removed if it is in use by ManagedCluster or TemplateChain 2. ClusterTemplate or ServiceTemplate can't be removed if the template is managed by the TemplateManagement 3. ProviderTemplate can't be removed if it's a core provider or enabled in Management spec.providers
eromanova
force-pushed
the
template-validation
branch
from
30564da
to
dca242a
Compare
eromanova
commented
Nov 21, 2024
| @@ -231,9 +231,6 @@ var _ = Describe("Template Chain Controller", func() { | |||
|
|
|||
| Eventually(k8sClient.Get, 1*time.Minute, 5*time.Second).WithArguments(ctx, chain, clusterTemplateChainResource).Should(HaveOccurred()) | |||
| } | |||
| for _, template := range []*hmcmirantiscomv1alpha1.ClusterTemplate{ctTemplates["test"], ctTemplates["ct0"], ctTemplates["ct2"]} { | |||
There was a problem hiding this comment.
Removing the templates' cleanup since the webhook now denies these requests. Templates have owner reference set and should be automatically deleted by the garbage collector. The owner reference existence is checked below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following template deletion rules are validated:
ClusterTemplateorServiceTemplatecan't be removed if it is in use byManagedClusterClusterTemplateorServiceTemplatecan't be removed if the template is managed byTemplateManagementProviderTemplatecan't be removed if it's a core provider or enabled in Managementspec.providersCloses #329