Including Ofx160.dtd as native option on SgmlReader #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not really necessary, the user can always include the OFX.dtd in their own app. The only reason I included HTML in SgmlReader is because it is such a common use case. |
|
I Agree @lovettchris , Anyway I think bringing this inside is a much more straightfoward way for those who are looking for an Ofx Reader (my case). :) And in an architectural point of view, I expect the cases that this .dtd is shared with the rest of the application will be far from usual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables SgmlReader to use option "ofx" in a native way.