Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on comments from #16093 #16384

Open
wants to merge 2 commits into
base: compatible
Choose a base branch
from
Open

Follow up on comments from #16093 #16384

wants to merge 2 commits into from

Conversation

deepthiskumar
Copy link
Member

Addressing final non-blocking comments from #16093

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@deepthiskumar deepthiskumar requested a review from a team as a code owner November 25, 2024 08:53
Base automatically changed from fabrizio-m/wide-merkle-queries to compatible November 25, 2024 12:31
@deepthiskumar
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthiskumar @mrmr1993