Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network identifier support #71

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Network identifier support #71

merged 5 commits into from
Nov 22, 2024

Conversation

piotr-iohk
Copy link
Collaborator

This PR covers #66.

Since network validation is required for most of the queries the PR introduces DashMap caching in the validate_network function to minimize redundant GraphQL queries.

Copy link
Member

@joaosreis joaosreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

P.S. I suggest using this cache mechanism to fetch and store the genesis block information from GraphQL, in favor of configuring it manually. I believe it's best to avoid different sources of truth, and we should rely on the information provided by the node we are connected to the most we can. I propose this in #72.

@piotr-iohk piotr-iohk merged commit 124e271 into main Nov 22, 2024
6 checks passed
@piotr-iohk piotr-iohk deleted the network_identifier_support branch November 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants