Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add selectUpload config option to ImageBlock #1559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geertplaisier
Copy link

@geertplaisier geertplaisier commented Nov 13, 2024

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Currently it is possible to configure an onUpload method for the ImageBlock component. This allows you to upload the selected image and return the URL. For our application we already have a collection of images available and it would be nice if the user could also select an image instead of always uploading a new one.

For this I added an selectUpload method which can be configured for the ImageBlock component. This expects a Promise as return value, which works similar to the onUpload configuration option but does not pass a file. Hopefully this is useful for others as well.

How did you test this change?

Since the implementation for this can vary a lot for each implementation, I added a Storybook story to demonstrate the behavior.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: c22666b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 3:40pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant