feat: add selectUpload config option to ImageBlock #1559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it is possible to configure an
onUpload
method for theImageBlock
component. This allows you to upload the selected image and return the URL. For our application we already have a collection of images available and it would be nice if the user could also select an image instead of always uploading a new one.For this I added an
selectUpload
method which can be configured for theImageBlock
component. This expects a Promise as return value, which works similar to theonUpload
configuration option but does not pass a file. Hopefully this is useful for others as well.How did you test this change?
Since the implementation for this can vary a lot for each implementation, I added a Storybook story to demonstrate the behavior.