fix(crepe): submits buttons in table and code block (#1532)

* fix(crepe): submits buttons in table and code block * chore: fix formatting * chore: fix formatting
Milkdown · Oct 14, 2024 · ccda9d8 · ccda9d8
1 parent 6d36b40
commit ccda9d8
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/packages/components/src/code-block/view/component.ts b/packages/components/src/code-block/view/component.ts
@@ -169,6 +169,7 @@ export const codeComponent: Component<CodeComponentProps> = ({
   return html`<host class=${clsx(selected && 'selected')}>
     <div class="tools">
       <button
+        type="button"
         ref=${triggerRef}
         class="language-button"
         onpointerdown=${onTogglePicker}

diff --git a/packages/components/src/table-block/view/component.ts b/packages/components/src/table-block/view/component.ts
@@ -88,6 +88,7 @@ export const tableComponent: Component<TableComponentProps> = ({
       onpointerleave=${pointerLeave}
     >
       <button
+        type="button"
         data-show="false"
         contenteditable="false"
         draggable="true"
@@ -105,21 +106,30 @@ export const tableComponent: Component<TableComponentProps> = ({
           class="button-group"
           onpointermove=${(e: PointerEvent) => e.stopPropagation}
         >
-          <button onpointerdown=${onAlign('left')}>
+          <button
+            type="button"
+            onpointerdown=${onAlign('left')}>
             ${config?.renderButton('align_col_left')}
           </button>
-          <button onpointerdown=${onAlign('center')}>
+          <button
+            type="button"
+            onpointerdown=${onAlign('center')}>
             ${config?.renderButton('align_col_center')}
           </button>
-          <button onpointerdown=${onAlign('right')}>
+          <button
+            type="button"
+            onpointerdown=${onAlign('right')}>
             ${config?.renderButton('align_col_right')}
           </button>
-          <button onpointerdown=${deleteSelected}>
+          <button
+            type="button"
+            onpointerdown=${deleteSelected}>
             ${config?.renderButton('delete_col')}
           </button>
         </div>
       </button>
       <button
+        type="button"
         data-show="false"
         contenteditable="false"
         draggable="true"
@@ -137,7 +147,9 @@ export const tableComponent: Component<TableComponentProps> = ({
           class="button-group"
           onpointermove=${(e: PointerEvent) => e.stopPropagation}
         >
-          <button onpointerdown=${deleteSelected}>
+          <button
+            type="button"
+            onpointerdown=${deleteSelected}>
             ${config?.renderButton('delete_row')}
           </button>
         </div>
@@ -163,7 +175,10 @@ export const tableComponent: Component<TableComponentProps> = ({
           onpointermove=${(e: PointerEvent) => e.stopPropagation}
           ref=${xLineHandleRef}
         >
-          <button onclick=${onAddRow} class="add-button">
+          <button
+            type="button"
+            onclick=${onAddRow}
+            class="add-button">
             ${config?.renderButton('add_row')}
           </button>
         </div>
@@ -176,7 +191,10 @@ export const tableComponent: Component<TableComponentProps> = ({
           onpointermove=${(e: PointerEvent) => e.stopPropagation}
           ref=${yLineHandleRef}
         >
-          <button onclick=${onAddCol} class="add-button">
+          <button
+            type="button"
+            onclick=${onAddCol}
+            class="add-button">
             ${config?.renderButton('add_col')}
           </button>
         </div>