Adds a possibility to access the first Token of a SyntaxNode. #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to add a getFirstToken() as a modifiable value, this structure will allows retrieving a token by address rather than by value. There is no real need to get a constptr though so it is not implemented.
Allows to retrieve a mutable version of a token of any SyntaxNode, and in particular the first and last token.
Adds the getTokenPtr function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 93.76% 93.67% -0.10%
==========================================
Files 189 189
Lines 47139 47187 +48
==========================================
Hits 44201 44201
- Misses 2938 2986 +48
Continue to review full report in Codecov by Sentry.
|
suzizecat
force-pushed
the
900-get-first-token
branch
from
ff6bafc to
a5c3f07
Compare
|
Nice, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #900 (and, by extension #898 )
This PR adds the
getChildPtr,getTokenPtr,getFirstTokenPtrandgetLastTokenPtrfunctions as well as required backend.Please let me know how to ensure the tests are still relevant and everything is covered if required.