Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slang-tidy] Fix segmentation fault during mapping checker name on the group #883

Conversation

likeamahoney
Copy link
Contributor

There is a segfault when existing checker is mapped to else's group

For example (segfault - no-old-always-syntax is from style group but not synthesis):

./build/gcc-11-release/bin/slang-tidy --config-file="Checks:-*,synthesis-no-old-always-syntax" test.sv

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de03987) 93.76% compared to head (fd26280) 93.76%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files         189      189           
  Lines       46866    46866           
=======================================
  Hits        43942    43942           
  Misses       2924     2924           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de03987...fd26280. Read the comment docs.

@MikePopoloski MikePopoloski merged commit 2423734 into MikePopoloski:master Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants