[slang-tidy] Fix NoOldAlwaysSyntax checker segmentation fault #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
LHSSymbol
collector from ASTHelpers may storenullptr
value when - assignment lhs is notlvalue
directy (for example -{x} = 1;
) and at another cases. Then it leads to segmentation fault atNoOldAlwaysSyntax
checker when stored lhs value is dereferenced.How to reproduce:
bug.sv
file:NoOldAlwaysSyntax
checker on it at any build. For example:./build/gcc-11-release/bin/slang-tidy --config-file="Checks:-*, style-no-old-always-syntax" bug.sv