[slang-tidy] fix slang-tidy's config-file option #856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem deal with "--config-file" slang-tidy option (file: tools/tidy/src/tidy.cpp line: 76)
The TidyConfigParser constructor have either "std::filesystem::path"(to open file) or "std::string" (for getting config from the string).
The " TidyConfigParser(const std::string& config)" version is selected here in any case instead of "TidyConfigParser(const std::filesystem::path& path)" in case of file exist.
I propose call "TidyConfigParser(std::filesystem::path(tidyConfigFile.value()))" in the file exist case and leave as is other-wise.