slang-reflect fixes on data assignment and namespaces #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not checking if a struct member was greater than 64 bits when giving it a value in the struct constructor, and always using the to_uint64() function loosing data in the conversion.
When returning a non-primitive type from a get_* function, we were assuming that the type was part of the current namespace, which is not always true. This commit fixes this issue by adding the namespace when necessary.
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 191 191
Lines 46354 46354
=======================================
Hits 43436 43436
Misses 2918 2918 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR provides two fixes for
slang-reflect: