SmallVector.h: avoid casting away constness #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting to `void*` removes constness if `T` is a `const` type. Even though the casting here is safe (i.e., no modifications are made), some compilers warn about the cast anway. Avoid casting away constness to remove some picky compiler warnings.
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 191 191
Lines 46208 46208
=======================================
Hits 43276 43276
Misses 2932 2932
Continue to review full report in Codecov by Sentry.
|
jameshanlon
added a commit
to jameshanlon/slang
that referenced
this pull request
Sep 16, 2023
* master: Add checking for streaming operators that produce values larger than the maximum object size Type::getBitstreamWidth can now return a uint32_t, no possibility for overflow Rename bitstreamWidth -> getBitstreamWidth Enforce bitstream width limits for classes inside structs, unpacked arrays SmallVector.h: avoid casting away constness (MikePopoloski#821) Win32: add missing manifest to tool unittest executables Fix gcc + clang warnings chore: update pre-commit hooks (MikePopoloski#820) Tweak message for ObjectTooLarge diagnostic Error if a declared class type is too large Remove unreachable diagnostic path for bits of dynamic type Remove wchar special cases for Windows now that it can use UTF-8 as the active code page Win32: add a manifest to set the active code page to utf-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting to
void*removes constness ifTis aconsttype. Even though the casting here is safe (i.e., no modifications are made), some compilers warn about the cast anyway. Avoid casting away constness to remove some picky compiler warnings.