Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-loaded buffers in SourceLoader #1164

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

povik
Copy link
Contributor

@povik povik commented Oct 22, 2024

Hi,

please see if this is acceptable. I have a use-case where I want to use Driver to get standard slang command line parsing, but I want to inject a piece of input which doesn't originate from a file.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.79%. Comparing base (f4e8ec4) to head (f19a57f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
source/driver/SourceLoader.cpp 54.54% 5 Missing ⚠️
include/slang/driver/SourceLoader.h 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
- Coverage   94.80%   94.79%   -0.02%     
==========================================
  Files         191      193       +2     
  Lines       49873    50003     +130     
==========================================
+ Hits        47280    47398     +118     
- Misses       2593     2605      +12     
Files with missing lines Coverage Δ
include/slang/driver/SourceLoader.h 77.77% <50.00%> (-22.23%) ⬇️
source/driver/SourceLoader.cpp 91.97% <54.54%> (-1.26%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e8ec4...f19a57f. Read the comment docs.

Copy link
Owner

@MikePopoloski MikePopoloski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems fine to me, just one comment to fix.

include/slang/driver/SourceLoader.h Outdated Show resolved Hide resolved
@povik
Copy link
Contributor Author

povik commented Oct 25, 2024

I have addressed the comment.

@MikePopoloski MikePopoloski merged commit 0a64646 into MikePopoloski:master Oct 25, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants