-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lexer detection of translate_on/off pragmas #1157
Add lexer detection of translate_on/off pragmas #1157
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 94.84% 94.63% -0.21%
==========================================
Files 191 195 +4
Lines 47944 50261 +2317
==========================================
+ Hits 45472 47566 +2094
- Misses 2472 2695 +223
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems ok. I think there must be a way to optimize it a bit more to avoid going into the full loop to check for cases since 99.9% of comments won't match, but it's probably ok for now.
You do need to add tests though; ideally you get full coverage of all branches, especially for something critical like the lexer.
OK, I have started some testing, let me see what the report will say |
Looks like the coverage is full |
Follow-up to #1100 with a changed approach. The detection now happens in lexer, not preprocessor. Tests are missing.