Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update _PyLong_AsByteArray call for Python 3.13 API changes #1148

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

vowstar
Copy link
Contributor

@vowstar vowstar commented Oct 9, 2024

  • Corrected the function call to _PyLong_AsByteArray for Python 3.13.
  • Added the missing 'with_exceptions' argument based on the new signature.
  • Ensured backward compatibility with Python versions before 3.13.

Closes: #1147

- Corrected the function call to _PyLong_AsByteArray for Python 3.13.
- Added the missing 'with_exceptions' argument based on the new signature.
- Ensured backward compatibility with Python versions before 3.13.

Closes: MikePopoloski#1147
Signed-off-by: Huang Rui <[email protected]>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (71ba68b) to head (3632175).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files         191      191           
  Lines       47929    47929           
=======================================
  Hits        45457    45457           
  Misses       2472     2472           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ba68b...3632175. Read the comment docs.

@MikePopoloski MikePopoloski merged commit ffba2de into MikePopoloski:master Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Failure with Python 3.13 Due to Missing Argument in _PyLong_AsByteArray
2 participants