Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locations in presence of nested trivia, take 2 #1136

Merged

Conversation

povik
Copy link
Contributor

@povik povik commented Sep 30, 2024

Follow-up from #1035

I gave up on making the change to eradicate nested trivia, instead I made effort to make the explicit locations on trivia consistently defined.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.77%. Comparing base (8174a94) to head (fe6b1bb).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
source/parsing/Token.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   94.76%   94.77%   +0.01%     
==========================================
  Files         191      191              
  Lines       47716    47803      +87     
==========================================
+ Hits        45217    45305      +88     
+ Misses       2499     2498       -1     
Files with missing lines Coverage Δ
include/slang/parsing/Token.h 100.00% <ø> (ø)
source/parsing/Preprocessor.cpp 100.00% <100.00%> (ø)
source/parsing/Token.cpp 93.31% <92.85%> (-0.15%) ⬇️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8174a94...fe6b1bb. Read the comment docs.

@MikePopoloski MikePopoloski merged commit 39d3d29 into MikePopoloski:master Oct 3, 2024
15 checks passed
@povik povik deleted the bugfix/nested-trivia branch October 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants