Netlist: add option to control unrolling of procedural for loops #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 191 191
Lines 47757 47757
=======================================
Hits 45260 45260
Misses 2497 2497 Continue to review full report in Codecov by Sentry.
|
|
Not to be landed please until I've figured out what is causing an infinite loop! |
|
Okay, good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also removes the logic that implements some ad-hoc data dependencies in procedural blocks.
This means that the netlist tool takes a clearer default position that no data dependencies are captured within them, which is perfectly reasonable for most use cases.