Fix infinite loop when analyzing invalid net alias expressions

MikePopoloski · Nov 24, 2024 · fed2ddf · fed2ddf
1 parent 2be8c63
commit fed2ddf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/source/ast/symbols/MemberSymbols.cpp b/source/ast/symbols/MemberSymbols.cpp
@@ -2460,7 +2460,7 @@ std::span<const Expression* const> NetAliasSymbol::getNetReferences() const {
     }
 
     netRefs = buffer.copy(scope->getCompilation());
-    if (issuedError)
+    if (issuedError || netAliases.empty())
         return *netRefs;
 
     // Compare every net alias expression to every other, finding the set of

diff --git a/tests/unittests/ast/MemberTests.cpp b/tests/unittests/ast/MemberTests.cpp
@@ -2404,3 +2404,12 @@ endmodule
     compilation.addSyntaxTree(tree);
     NO_COMPILATION_ERRORS;
 }
+
+TEST_CASE("Net alias infinite loop regress") {
+    auto tree = SyntaxTree::fromText(R"(
+alias;
+)");
+
+    Compilation compilation;
+    compilation.addSyntaxTree(tree);
+}