Skip to content

Commit

Permalink
Make gcc 11 the minimum required version
Browse files Browse the repository at this point in the history
  • Loading branch information
MikePopoloski committed Sep 23, 2023
1 parent 2825b67 commit facbeb4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
os: ubuntu-22.04
- preset: gcc-release
os: ubuntu-22.04
- preset: gcc-10-release
- preset: gcc-11-release
os: ubuntu-22.04
- preset: gcc-debug-shared
os: ubuntu-22.04
Expand All @@ -43,7 +43,7 @@ jobs:
sudo add-apt-repository "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main"
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install -y g++-13 g++-10 clang-17 clang-tidy-17
sudo apt-get install -y g++-13 g++-11 clang-17 clang-tidy-17
- uses: ilammy/msvc-dev-cmd@v1
if: matrix.os == 'windows-latest'
- uses: maxim-lobanov/setup-xcode@v1
Expand Down
4 changes: 2 additions & 2 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,15 @@
}
},
{
"name": "gcc-10-release",
"name": "gcc-11-release",
"displayName": "GCC Release",
"inherits": [
"linux-base",
"gcc-flags"
],
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"CMAKE_CXX_COMPILER": "g++-10"
"CMAKE_CXX_COMPILER": "g++-11"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion docs/building.dox
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ slang requires the following tools in order to build:
- [python 3](https://www.python.org/)
- [CMake](https://cmake.org/) (3.20 or later)
- C++20 compatible compiler. Minimum supported compiler versions:
- GCC 10
- GCC 11
- clang 16
- Xcode 15
- MSVC support is tested only against the most recent update of VS 2022
Expand Down
3 changes: 0 additions & 3 deletions source/ast/ASTSerializer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ void ASTSerializer::writeProperty(std::string_view name) {

template<typename T>
void ASTSerializer::visit(const T& elem, bool inMembersArray) {
// TODO: remove once we no longer support gcc-10
(void)inMembersArray;

if constexpr (std::is_base_of_v<Expression, T>) {
writer.startObject();
write("kind", toString(elem.kind));
Expand Down

0 comments on commit facbeb4

Please sign in to comment.