[slang][parser] Fix timeless constraint expression parsing

MikePopoloski · Sep 17, 2024 · c0feaa5 · c0feaa5
1 parent d077ed8
commit c0feaa5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/source/syntax/SyntaxFacts.cpp b/source/syntax/SyntaxFacts.cpp
@@ -347,8 +347,6 @@ bool SyntaxFacts::isPossibleExpression(TokenKind kind) {
             // to provide good error handling
         case TokenKind::DoubleColon:
         case TokenKind::Question:
-        case TokenKind::MatchesKeyword:
-        case TokenKind::TripleAnd:
         case TokenKind::InsideKeyword:
         case TokenKind::DistKeyword:
             return true;

diff --git a/tests/unittests/parsing/MemberParsingTests.cpp b/tests/unittests/parsing/MemberParsingTests.cpp
@@ -1489,3 +1489,15 @@ endmodule
     REQUIRE(diagnostics.size() == 1);
     CHECK(diagnostics[0].code == diag::UnexpectedEndDelim);
 }
+
+TEST_CASE("Bad top level constraints") {
+    auto& text = R"(
+constraint A :: A { &&& }
+constraint A :: A { matches }
+)";
+    parseCompilationUnit(text);
+
+    REQUIRE(diagnostics.size() == 2);
+    CHECK(diagnostics[0].code == diag::ExpectedMember);
+    CHECK(diagnostics[1].code == diag::ExpectedMember);
+}