Fix parser error when invalid class override specifiers exists at the…

… end of a file
MikePopoloski · Nov 26, 2024 · 47ccb86 · 47ccb86
1 parent 051c03f
commit 47ccb86
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/source/parsing/Parser_members.cpp b/source/parsing/Parser_members.cpp
@@ -999,9 +999,12 @@ ClassSpecifierSyntax* Parser::parseClassSpecifier() {
             case TokenKind::FinalKeyword:
                 keyword = consume();
                 break;
-            default:
+            case TokenKind::Identifier:
                 skipToken(diag::ExpectedClassSpecifier);
                 break;
+            default:
+                addDiag(diag::ExpectedClassSpecifier, peek().location());
+                break;
         }
 
         auto& result = factory.classSpecifier(colon, keyword);

diff --git a/tests/unittests/parsing/MemberParsingTests.cpp b/tests/unittests/parsing/MemberParsingTests.cpp
@@ -1522,3 +1522,12 @@ endclass
     REQUIRE(diagnostics.size() == 1);
     CHECK(diagnostics[0].code == diag::SpecifiersNotAllowed);
 }
+
+TEST_CASE("Class specifier parsing crash regress") {
+    auto& text = R"(
+task:
+)";
+
+    parseCompilationUnit(text, LanguageVersion::v1800_2023);
+    REQUIRE(diagnostics.size() == 3);
+}