[slang-tidy] Fix NoOldAlwaysSyntax checker segmentation fault

MikePopoloski · Jan 30, 2024 · 1416be9 · 1416be9
1 parent de03987
commit 1416be9
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/tools/tidy/include/ASTHelperVisitors.h b/tools/tidy/include/ASTHelperVisitors.h
@@ -55,7 +55,8 @@ struct CollectIdentifiers : public slang::ast::ASTVisitor<CollectIdentifiers, fa
 /// ASTVisitor that will collect all LHS assignment symbols under a node
 struct CollectLHSSymbols : public slang::ast::ASTVisitor<CollectLHSSymbols, true, true> {
     void handle(const slang::ast::AssignmentExpression& expression) {
-        symbols.push_back(expression.left().getSymbolReference());
+        if (const auto symbol = expression.left().getSymbolReference(); symbol)
+            symbols.push_back(symbol);
     }
 
     std::vector<const slang::ast::Symbol*> symbols;

diff --git a/tools/tidy/tests/NoOldAlwaysSyntaxTest.cpp b/tools/tidy/tests/NoOldAlwaysSyntaxTest.cpp
@@ -199,3 +199,27 @@ endmodule
     bool result = visitor->check(root);
     CHECK(result);
 }
+
+TEST_CASE("NoOldAlwaysSyntax: composite lhs") {
+    auto tree = SyntaxTree::fromText(R"(
+module top();
+    logic n;
+
+    always @(*) begin
+        {n} = 1;
+    end
+endmodule
+)");
+
+    Compilation compilation;
+    compilation.addSyntaxTree(tree);
+    compilation.getAllDiagnostics();
+    auto& root = compilation.getRoot();
+
+    TidyConfig config;
+    Registry::setConfig(config);
+    Registry::setSourceManager(compilation.getSourceManager());
+    auto visitor = Registry::create("NoOldAlwaysSyntax");
+    bool result = visitor->check(root);
+    CHECK(result);
+}