Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to whitelist specific query names when adding graphql middleware #29

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

MikaAK
Copy link
Owner

@MikaAK MikaAK commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16% 🎉

Comparison is base (d38708d) 94.54% compared to head (47a8317) 94.70%.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/no-error-caching      #29      +/-   ##
=========================================================
+ Coverage                  94.54%   94.70%   +0.16%     
=========================================================
  Files                          9        9              
  Lines                        165      170       +5     
=========================================================
+ Hits                         156      161       +5     
  Misses                         9        9              
Files Changed Coverage Δ
lib/request_cache/plug.ex 95.60% <ø> (ø)
lib/request_cache/middleware.ex 96.00% <100.00%> (+1.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikaAK MikaAK merged commit 149e3b5 into feat/no-error-caching Sep 22, 2023
7 checks passed
@MikaAK MikaAK deleted the feat/whitelisted-query branch September 22, 2023 19:22
MikaAK added a commit that referenced this pull request Sep 26, 2023
* feat: add tests for caching on error cases and increase test coverage

* chore: remove caching of errors and make it a tunable configuration to cache errors

* fix: deep merge changes into resolution context and plug/private to avoid overriding things

* fix: format unformatted code and fix telemetry tests causing log messages

* fix: up coverage requirements for project to 90%

* feat: add ability to whitelist specific query names when adding graphql middleware (#29)

* feat: add ability to whitelist specific query names when adding graphql middleware

* chore: add docs for whitelisting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants