Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Array.countBy and some fixes to List.countBy #224

Merged
merged 6 commits into from
Jul 18, 2016

Conversation

liboz
Copy link
Contributor

@liboz liboz commented Jul 16, 2016

Related to #184

@orcabot
Copy link
Contributor

orcabot commented Jul 16, 2016

@orcabot
Copy link
Contributor

orcabot commented Jul 16, 2016

Hi! I'm your friendly content validation bot. For this PR to be labeled as ready-to-merge, you'll need at least 2 comments from our designated community approvers containing the magic phrase LGTM (Looks good to me also works, for those of us that are really verbose).

@dend @KevinRansom @cartermp @thedanfernandez @dsyme - please validate this PR.

@orcabot
Copy link
Contributor

orcabot commented Jul 16, 2016

@dend
Copy link
Contributor

dend commented Jul 18, 2016

This LGTM as long as @cartermp can validate the code.

@@ -0,0 +1,6 @@
let array1 = [| 1 .. 100 |]
let printArray anarray = Array.iter (printf "%A ") anarray; printfn ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change:

let printArray anarray =
    anarray |> Array.iter (printf "%A ")
    printfn ""

Generally avoiding semicolons is a good thing for samples, as they're hard for people to catch when reading.

…ot use a semicolon and instead use piping/newlines
@orcabot
Copy link
Contributor

orcabot commented Jul 18, 2016

@orcabot
Copy link
Contributor

orcabot commented Jul 18, 2016

@cartermp
Copy link
Contributor

LGTM. Thanks, @liboz!

@orcabot orcabot merged commit 6ec8a2b into MicrosoftDocs:master Jul 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants