Enforce non-negative percents for material.add_nuclide to prevent uni…

…ntended ao/wo flipping (openmc-dev#3075)
MicahGale · Jul 8, 2024 · e74dc50 · e74dc50
1 parent b11f8b7
commit e74dc50
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/openmc/material.py b/openmc/material.py
@@ -519,6 +519,7 @@ def add_nuclide(self, nuclide: str, percent: float, percent_type: str = 'ao'):
         cv.check_type('nuclide', nuclide, str)
         cv.check_type('percent', percent, Real)
         cv.check_value('percent type', percent_type, {'ao', 'wo'})
+        cv.check_greater_than('percent', percent, 0, equality=True)
 
         if self._macroscopic is not None:
             msg = 'Unable to add a Nuclide to Material ID="{}" as a ' \
@@ -727,6 +728,7 @@ def add_element(self, element: str, percent: float, percent_type: str = 'ao',
 
         cv.check_type('nuclide', element, str)
         cv.check_type('percent', percent, Real)
+        cv.check_greater_than('percent', percent, 0, equality=True)
         cv.check_value('percent type', percent_type, {'ao', 'wo'})
 
         # Make sure element name is just that