-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch eval result comparison from GH workflow artifact #435
Conversation
375d17f
to
2517934
Compare
29dfda1
to
62c96ff
Compare
Should we add a bit more verbosity ? |
62c96ff
to
b394021
Compare
It's a good idea. One thing I like about nixpkgs-review is that it always prints out what it's doing in a manually reproducible way. This way, it automates the review task without becoming another black box that reviewers need to debug. |
9a4470c
to
9ff1ae4
Compare
502d4a9
to
e708ddc
Compare
Hmm, it's not working currently. |
070e746
to
4466fc8
Compare
update test_pr_github_action_eval mocks
4466fc8
to
93190db
Compare
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify refresh |
@mergify queue |
✅ Pull request refreshed |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ff1f0c8 |
nixpkgs-review
can now retrieve the list of rebuilds to do in the GitHub Eval action artifact.Leverages NixOS/nixpkgs#363751 to resolve #433.