Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch eval result comparison from GH workflow artifact #435

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

GaetanLepage
Copy link
Contributor

nixpkgs-review can now retrieve the list of rebuilds to do in the GitHub Eval action artifact.
Leverages NixOS/nixpkgs#363751 to resolve #433.

  • rename OFBORG_PLATFORMS to PLATFORMS
  • Fetch eval result comparison from GH workflow artifact

@GaetanLepage GaetanLepage force-pushed the gh-action-eval branch 4 times, most recently from 375d17f to 2517934 Compare December 14, 2024 22:25
@GaetanLepage GaetanLepage marked this pull request as ready for review December 14, 2024 22:25
@GaetanLepage GaetanLepage force-pushed the gh-action-eval branch 3 times, most recently from 29dfda1 to 62c96ff Compare December 14, 2024 22:31
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Dec 14, 2024

Should we add a bit more verbosity ?
For example, telling which eval strategy is currently being tried.

@GaetanLepage GaetanLepage changed the title gh action eval Fetch eval result comparison from GH workflow artifact Dec 15, 2024
@ShamrockLee
Copy link

Should we add a bit more verbosity?
For example, telling which eval strategy is currently being tried.

It's a good idea. One thing I like about nixpkgs-review is that it always prints out what it's doing in a manually reproducible way. This way, it automates the review task without becoming another black box that reviewers need to debug.

@GaetanLepage GaetanLepage force-pushed the gh-action-eval branch 3 times, most recently from 9a4470c to 9ff1ae4 Compare December 17, 2024 22:05
@GaetanLepage
Copy link
Contributor Author

Added basic logging:
image

Feel free to make additional suggestions.

@Mic92 Mic92 force-pushed the gh-action-eval branch 2 times, most recently from 502d4a9 to e708ddc Compare December 17, 2024 23:42
@GaetanLepage
Copy link
Contributor Author

Hmm, it's not working currently.

@Mic92 Mic92 force-pushed the gh-action-eval branch 5 times, most recently from 070e746 to 4466fc8 Compare December 18, 2024 00:34
@Mic92
Copy link
Owner

Mic92 commented Dec 18, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 18, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #435 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Owner

Mic92 commented Dec 18, 2024

@mergify refresh

@Mic92
Copy link
Owner

Mic92 commented Dec 18, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 18, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

mergify bot commented Dec 18, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ff1f0c8

@mergify mergify bot merged commit ff1f0c8 into Mic92:master Dec 18, 2024
4 checks passed
Repository owner deleted a comment from mergify bot Dec 18, 2024
@GaetanLepage GaetanLepage deleted the gh-action-eval branch December 18, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA eval support
3 participants