feat: add --hook to run commands when done thinking
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test fail |
Mic92
reviewed
Oct 18, 2023
Mic92
reviewed
Oct 18, 2023
| @@ -579,6 +584,7 @@ def review_local_revision( | |||
| build_graph=args.build_graph, | |||
| nixpkgs_config=nixpkgs_config, | |||
| extra_nixpkgs_config=args.extra_nixpkgs_config, | |||
| hook=args.hook, | |||
There was a problem hiding this comment.
This Result class also needs this field. You can use mypy nixpkgs_review to test it for type errors like this.
There was a problem hiding this comment.
When I run it I get:
mypy nixpkgs_review
Success: no issues found in 20 source files
Not sure what a result class is in this context
There was a problem hiding this comment.
When I run it I get:
mypy nixpkgs_review Success: no issues found in 20 source filesNot sure what a result class is in this context
Rebase the branch, before #371 a --strict was needed
Signed-off-by: Christina Sørensen <[email protected]>
|
I'm not sure I understand python enough to fix this for now, might reopen later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--hookflag to theprsubcommand.This is useful for e.g. running
notify-send "done building", sending mail, orany arbitrary thing you might wanna do when
nixpkgs-reviewis done bulding.It's been a long time since I wrote any python, and I have no grasp on this
codebase, so appologies if I made a mess!