Remove warning from github eval fetching

Mic92 · Jan 5, 2025 · 74322ca · 74322ca
1 parent d326eac
commit 74322ca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/nixpkgs_review/github.py b/nixpkgs_review/github.py
@@ -9,7 +9,7 @@
 from pathlib import Path
 from typing import IO, Any, override
 
-from .utils import System, warn
+from .utils import System
 
 
 def pr_url(pr: int) -> str:
@@ -175,32 +175,17 @@ def get_github_action_eval_result(
                 workflow_run["artifacts_url"],
             )["artifacts"]
 
-            found_comparison = False
             for artifact in artifacts:
                 if artifact["name"] != "comparison":
                     continue
-                found_comparison = True
                 changed_paths: Any = self.get_json_from_artifact(
                     workflow_id=artifact["id"],
                     json_filename="changed-paths.json",
                 )
                 if changed_paths is None:
-                    warn(
-                        f"Found comparison artifact, but no changed-paths.json in workflow {workflow_run['html_url']}"
-                    )
                     continue
                 if (path := changed_paths.get("rebuildsByPlatform")) is not None:
                     assert isinstance(path, dict)
                     return path
 
-            if not found_comparison:
-                if workflow_run["status"] == "queued":
-                    warn(
-                        f"Found eval workflow run, but evaluation is still work in progress: {workflow_run['html_url']}"
-                    )
-                else:
-                    warn(
-                        f"Found eval workflow run, but no comparison artifact in {workflow_run['html_url']}."
-                    )
-
         return None
diff --git a/nixpkgs_review/review.py b/nixpkgs_review/review.py
@@ -306,7 +306,8 @@ def build_pr(self, pr_number: int) -> dict[System, list[Attr]]:
                 timeout: int = 10
                 print(f"...Results are not (yet) available. Retrying in {timeout}s")
                 while packages_per_system is None:
-                    print(".", end="")
+                    print("---------------")
+                    # print(".", end="")
                     time.sleep(timeout)
                     packages_per_system = (
                         self.github_client.get_github_action_eval_result(pr)