Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added protoc runtime dep: CI fixes + Docker Compose fixes, adapted environment variables #8

Merged
merged 8 commits into from
Jan 15, 2024

Conversation

legendofa
Copy link
Collaborator

No description provided.

@legendofa legendofa changed the title Added protoc runtime dep + CI fixes + Docker Compose fixes Added protoc runtime dep: CI fixes + Docker Compose fixes, adapted environment variables Jan 14, 2024
@legendofa legendofa marked this pull request as draft January 14, 2024 21:57
@legendofa
Copy link
Collaborator Author

MongoDB credentials can be configured over the connection URI and are not required internally

@legendofa legendofa marked this pull request as ready for review January 15, 2024 12:43
@legendofa legendofa marked this pull request as draft January 15, 2024 12:55
@legendofa
Copy link
Collaborator Author

docker-compose-dev.yaml works. Wishlist can't reach the database in docker-compose-base.yaml, but docker-compose-dev.yaml works as well with the base-dockerfile.

@legendofa
Copy link
Collaborator Author

docker-compose-dev.yaml works. Wishlist can't reach the database in docker-compose-base.yaml, but docker-compose-dev.yaml works as well with the base-dockerfile.

Nevermind, this was a port mapping issue.

@legendofa legendofa marked this pull request as ready for review January 15, 2024 13:30
@legendofa legendofa requested a review from nk-coding January 15, 2024 13:30
Copy link
Contributor

@nk-coding nk-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a test build github action would be good

@legendofa legendofa merged commit 73a1434 into main Jan 15, 2024
1 check passed
@delvh delvh deleted the added-protoc-runtime-dep branch January 18, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants