-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial order service setup #1
Conversation
Ready for review, should be feature complete including authentication. Except for the outgoing events, those have to be added, but i am planning to do this in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, these are a lot of rather major changes, so I decided to postpone testing until answers/fixes.
Also, at that point please provide me with the GraphQL schema, as I have no working rust infrastructure locally, and do not want to have that much fun with docker exec :)
This makes testing the stuff with the gateway a lot easier
Also, please fix the Gropius issue |
The Devcontainer would be an easy way to get the schema. There you can run |
… events and GraphQL queries. Creating GraphQL queries and validating against the schema Repo submodule
…information in order item
TODO:
|
Should be fixed, except for the missing schema transformation step to fix the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment left, will probably approve after answer/change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Discount still has a discount field which must be gone
- optional: the enum entries could use some description (in GraphQL)
- ProductVariant still has fields currentVersion and isPubliclyVisisble which must be gone
- ProductVariantVersion still has fields price and taxRateId which must be gone
- TaxRateVersion still has fields rate and version which must be gone
Gropius issue: https://frontend.gropius.duckdns.org/components/b42870e5-9824-4c5a-9ea2-d1196fc0d740/issues/51adba3b-ed25-492a-bf4c-9e942f3151bd