Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial order service setup #1

Merged
merged 87 commits into from
Mar 28, 2024
Merged

Initial order service setup #1

merged 87 commits into from
Mar 28, 2024

Conversation

legendofa
Copy link
Collaborator

@legendofa legendofa commented Feb 18, 2024

Gropius issue: https://frontend.gropius.duckdns.org/components/b42870e5-9824-4c5a-9ea2-d1196fc0d740/issues/51adba3b-ed25-492a-bf4c-9e942f3151bd

  • Requirements of the issue are met
  • Code has been reviewed
  • Code is documented
  • GraphQL related artefacts are documented

@legendofa legendofa marked this pull request as ready for review February 19, 2024 17:03
@legendofa
Copy link
Collaborator Author

Ready for review, should be feature complete including authentication. Except for the outgoing events, those have to be added, but i am planning to do this in another PR.

@legendofa legendofa requested a review from nk-coding February 19, 2024 17:05
src/http_event_service.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@nk-coding nk-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, these are a lot of rather major changes, so I decided to postpone testing until answers/fixes.
Also, at that point please provide me with the GraphQL schema, as I have no working rust infrastructure locally, and do not want to have that much fun with docker exec :)
This makes testing the stuff with the gateway a lot easier

src/mutation.rs Outdated Show resolved Hide resolved
src/mutation.rs Outdated Show resolved Hide resolved
src/mutation_input_structs.rs Outdated Show resolved Hide resolved
src/mutation_input_structs.rs Outdated Show resolved Hide resolved
src/mutation_input_structs.rs Show resolved Hide resolved
src/order.rs Outdated Show resolved Hide resolved
src/order_item.rs Outdated Show resolved Hide resolved
src/query.rs Outdated Show resolved Hide resolved
src/mutation.rs Show resolved Hide resolved
@nk-coding
Copy link
Contributor

Also, please fix the Gropius issue

@legendofa
Copy link
Collaborator Author

So, these are a lot of rather major changes, so I decided to postpone testing until answers/fixes. Also, at that point please provide me with the GraphQL schema, as I have no working rust infrastructure locally, and do not want to have that much fun with docker exec :) This makes testing the stuff with the gateway a lot easier

The Devcontainer would be an easy way to get the schema. There you can run cargo run -- --generate-schema in the terminal then. But, i will send you the schema once i have made the requested changes.

src/main.rs Show resolved Hide resolved
@legendofa
Copy link
Collaborator Author

TODO:

  • Fix multiple key fields on 4 entities
  • Remove User.userAddressIds
  • Remove all non-id-fields from non-resolvable entities
  • Rename Address to UserAddress
  • GraphQL correct client schemas to fix CI

@legendofa
Copy link
Collaborator Author

GraphQL correct client schemas to fix CI

Should be fixed, except for the missing schema transformation step to fix the CI

Copy link
Contributor

@nk-coding nk-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left, will probably approve after answer/change

@legendofa legendofa requested a review from nk-coding March 27, 2024 20:52
Copy link
Contributor

@nk-coding nk-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Discount still has a discount field which must be gone
  • optional: the enum entries could use some description (in GraphQL)
  • ProductVariant still has fields currentVersion and isPubliclyVisisble which must be gone
  • ProductVariantVersion still has fields price and taxRateId which must be gone
  • TaxRateVersion still has fields rate and version which must be gone

@legendofa legendofa merged commit 8249070 into main Mar 28, 2024
2 checks passed
@legendofa legendofa deleted the order-setup branch May 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants