Make sort_name sortable 🙃 #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antidipyramid
approved these changes
Jul 25, 2024
| RECAPTCHA_PRIVATE_KEY=(str, ""), | ||
| # Test keys from: | ||
| # https://developers.google.com/recaptcha/docs/faq#id-like-to-run-automated-tests-with-recaptcha.-what-should-i-do | ||
| RECAPTCHA_PUBLIC_KEY=(str, "6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI"), |
There was a problem hiding this comment.
Locally, I had to remove the corresponding (empty) recaptcha variables from .env.local to get this to work. django-environ seems to parse empty variables as present and won't use the default.
We should probably remove these variables from .env.local.example.
There was a problem hiding this comment.
Great catch. Done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the configuration of the sort_name field so ElasticSearch will actually sort by it. Reference: django-haystack/django-haystack#569
Connects #1142
Testing Instructions
This change requires an index rebuild to take effect, so you'll have to test locally.