Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle proper broadcast becoming avail while there's a manual one #1132

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

xmedr
Copy link
Collaborator

@xmedr xmedr commented Jul 3, 2024

Overview

This accounts for the edge case where an event with a manually published broadcast link gets access to a proper broadcast link. Previously, the conditionals in the event template would hide the option to unpublish a link if a proper link was available, making it difficult to unpublish that event's manual broadcast if it existed. This allows for that button to be available if both a manual and proper broadcast link exist.

Notes

The connected issue describes two improvements, but I'll do this one first because it'll be easier to test now before the second improvement comes in.

Testing Instructions

@fgregg fgregg temporarily deployed to la-metro-cou-patch-manu-sjjazy July 3, 2024 14:16 Inactive
@xmedr xmedr changed the title Handle proper broadcast becoming avail while there's a manual one Handle manual broadcast edge cases Jul 3, 2024
@xmedr xmedr changed the title Handle manual broadcast edge cases Handle proper broadcast becoming avail while there's a manual one Jul 3, 2024
@xmedr xmedr requested a review from antidipyramid July 3, 2024 14:29
@xmedr xmedr marked this pull request as ready for review July 3, 2024 14:29
@xmedr xmedr merged commit d629af8 into main Jul 15, 2024
2 checks passed
@xmedr xmedr deleted the patch/manual-broadcasts branch July 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants