Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent manual broadcast button from appearing when one exists #1128

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

xmedr
Copy link
Collaborator

@xmedr xmedr commented Jun 28, 2024

Overview

This is a fix for a bug in pr #1112. On staging, the logic for preventing a user from publishing another broadcast when one already existed was not working because the manual_events variable that the event template was expecting didn't exist. This sets that up properly.

This also disallows the option to publish a manual broadcast both for past events that already have a regular broadcast available, and cancelled events.

Testing Instructions

**Note: since that last PR applied the migration for manual broadcasts, this can now be tested on the review app (using the staging database)

  • Publish an event
  • Go to another event's page. Confirm that:
    • An event without a proper broadcast does not allow publishing a second one, and provides a link to the initial event
    • An event with a proper broadcast or a cancelled event does not allow publishing a new one at all

@fgregg fgregg temporarily deployed to la-metro-cou-feature-ma-wom5su June 28, 2024 15:16 Inactive
@xmedr xmedr requested a review from antidipyramid June 28, 2024 15:45
@xmedr
Copy link
Collaborator Author

xmedr commented Jun 28, 2024

whenever this gets approved i'll test on staging proper one more time before deploying

@xmedr xmedr merged commit 04df15e into main Jul 1, 2024
2 checks passed
@xmedr xmedr deleted the feature/manual-broadcasts branch July 1, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants