Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch wasm file should append baseUrl base on currenScript running env #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joeyrenhuang
Copy link

Encountered a problem when use module federation. fetch wasm failed coz wasm locates different to window.location.origin, so here will get running env before fetch

@zuckschwerdt
Copy link

I encountered the same problem of needing to resolve the wasm file relative to the script url and not the current window.location.

@joeyrenhuang can you rebase to include the latest change (#50)?

@zuckschwerdt
Copy link

I've confirmed this working for my use-case, but it needs to not match @ in getRunningScript() so we don't prepend the function or code. For examples see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack
I.e. apply zuckschwerdt@eead35b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants