Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse ExportNamedDeclaration with source #46

Merged
merged 3 commits into from
Aug 8, 2024
Merged

fix: parse ExportNamedDeclaration with source #46

merged 3 commits into from
Aug 8, 2024

Conversation

pedrotainha
Copy link
Contributor

This PR fixes the parse of files that contain named exports directly from a source file.

closes #45

@Menci
Copy link
Owner

Menci commented Jul 19, 2024

I added tests and fixed the transform logic. The export ... from statement should NOT be transformed to import { id } from and export { id }. We shouldn't occupy extra identifiers.

Could you please review my changes again?

@Menci
Copy link
Owner

Menci commented Aug 8, 2024

Merging since no response.

@Menci Menci merged commit ae1190e into Menci:main Aug 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The plugin don't parse a file that only contains ´ExportNamedDeclaration´ with source
3 participants
@pedrotainha @Menci @pmtcofidis